Task#
V1-NYX-007Build sky chart or event-detail integrations appropriate for Oshun web.
Implementation#
- Extended the canonical Nyx event detail model in
apps/oshun/web/src/components/domains/nyx/nyxEventPageModels.tswith focused sky-chart handoff metadata, including mode selection, focus summaries, and shell-safe Nyx chart links. - Updated
apps/oshun/web/src/components/domains/nyx/NyxEventDetailWorkspace.tsxto expose explicit focused-chart entry points from the event page hero and a dedicated "Sky chart handoff" panel inside the event detail narrative. - Upgraded
apps/oshun/web/src/components/domains/NyxSurface.tsxto parse Nyx shellpathquery strings with embedded sky-map parameters and pass a focused event intent into the sky-map overlay. - Extended
apps/oshun/web/src/components/domains/nyx/sky-map/InteractiveSkyMap.tsxandapps/oshun/web/src/components/domains/nyx/SkyMapOverlay.tsxso the chart can accept event-specific focus intent, auto-center on known objects when possible, apply guided fallback framing when the event is broader than a single object, and render a visible focus panel describing the active event context. - Added supporting focused-chart styling in
apps/oshun/web/src/app/globals.css.
Coverage#
- Added event-model assertions in
apps/oshun/web/src/components/domains/nyx/__tests__/nyxEventPageModels.test.ts. - Expanded event-detail coverage in
apps/oshun/web/src/components/domains/nyx/__tests__/NyxEventDetailWorkspace.test.tsx. - Added Nyx shell routing coverage in
apps/oshun/web/src/components/domains/__tests__/NyxSurfaceSkyMapRouting.test.tsx. - Extended browser automation in
apps/oshun/web/e2e/nyx-event-pages.spec.tsfor the event-detail to focused-chart handoff.
Verification#
- Passed:
pnpm exec prettier --check apps/oshun/web/src/app/globals.css apps/oshun/web/src/components/domains/NyxSurface.tsx apps/oshun/web/src/components/domains/nyx/NyxEventDetailWorkspace.tsx apps/oshun/web/src/components/domains/nyx/SkyMapOverlay.tsx apps/oshun/web/src/components/domains/nyx/nyxEventPageModels.ts apps/oshun/web/src/components/domains/nyx/sky-map/InteractiveSkyMap.tsx apps/oshun/web/src/components/domains/__tests__/NyxSurfaceSkyMapRouting.test.tsx apps/oshun/web/src/components/domains/nyx/__tests__/NyxEventDetailWorkspace.test.tsx apps/oshun/web/src/components/domains/nyx/__tests__/nyxEventPageModels.test.ts apps/oshun/web/e2e/nyx-event-pages.spec.ts - Passed:
pnpm exec eslint --no-warn-ignored apps/oshun/web/src/components/domains/NyxSurface.tsx apps/oshun/web/src/components/domains/nyx/NyxEventDetailWorkspace.tsx apps/oshun/web/src/components/domains/nyx/SkyMapOverlay.tsx apps/oshun/web/src/components/domains/nyx/nyxEventPageModels.ts apps/oshun/web/src/components/domains/nyx/sky-map/InteractiveSkyMap.tsx apps/oshun/web/src/components/domains/__tests__/NyxSurfaceSkyMapRouting.test.tsx apps/oshun/web/src/components/domains/nyx/__tests__/NyxEventDetailWorkspace.test.tsx apps/oshun/web/e2e/nyx-event-pages.spec.ts - Passed:
pnpm exec vitest run apps/oshun/web/src/components/domains/nyx/__tests__/nyxEventPageModels.test.ts apps/oshun/web/src/components/domains/nyx/__tests__/NyxEventDetailWorkspace.test.tsx apps/oshun/web/src/components/domains/__tests__/NyxSurfaceSkyMapRouting.test.tsx - Passed: filtered
pnpm exec tsc --noEmit --pretty false -p apps/oshun/web/tsconfig.jsoncheck for the touched Nyx files returned no matches.
Blockers#
pnpm exec playwright test e2e/nyx-event-pages.spec.ts --project=chromiumcould not start because the configured Playwright web server boot path hits the host watcher limit:ENOSPC: System limit for number of file watchers reached, watch '/root/workspace/oshun-v1/apps/oshun/bff/src/server.ts'.- The Playwright spec was still added and updated as part of the task so the browser coverage is ready once the environment watcher ceiling is raised or the web-server startup path is adjusted.